Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envelope messages in IPC/WS #6613

Open
2 tasks
jdevcs opened this issue Nov 21, 2023 · 2 comments
Open
2 tasks

envelope messages in IPC/WS #6613

jdevcs opened this issue Nov 21, 2023 · 2 comments
Labels
4.x 4.0 related Investigate Maintenance Maintenance such as CI or linter changes

Comments

@jdevcs
Copy link
Contributor

jdevcs commented Nov 21, 2023

when you receive a JSON object which is larger than the buffer of the socket the json comes in chunks. openethereum/parity-ethereum#4647

  • Update dechunker logic in v4.
  • Verify it on Geth and Nethermind,( Besu )
@jdevcs jdevcs added Investigate 4.x 4.0 related labels Nov 21, 2023
@Muhammad-Altabba
Copy link
Contributor

Muhammad-Altabba commented Nov 28, 2023 •
edited
Loading

Our current code for parsing chunks is at:

web3.js/packages/web3-utils/src/chunk_response_parser.ts

Line 47 in e6d8c14

const dechunkedData = data
we will double check it...

Thanks Junaid,

@mconnelly8 mconnelly8 added the Maintenance Maintenance such as CI or linter changes label Nov 28, 2023
@jdevcs
Copy link
Contributor Author

jdevcs commented Nov 28, 2023

https://github.com/ethers-io/ethers.js/blob/39315288bee6f116e362e70c00f999ae669dd462/src.ts/providers/provider-ipcsocket.ts#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x 4.0 related Investigate Maintenance Maintenance such as CI or linter changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Muhammad-Altabba @jdevcs @mconnelly8 and others