Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix link in README to tree shaking guide #6817

Closed
0xthorazine opened this issue Feb 16, 2024 · 4 comments
Closed

[DOCS] Fix link in README to tree shaking guide #6817

0xthorazine opened this issue Feb 16, 2024 · 4 comments
Assignees
Labels
4.x 4.0 related Documentation Relates to project wiki or documentation Good First Issue Great to learn the internals of web3.js

Comments

@0xthorazine
Copy link
Contributor

Link in README to web3.js tree shaking guide points to a page that returns a 404

Expected behavior

Should go to the right page

Actual behavior

404 error

Steps to reproduce the behavior

Click the link

@SantiagoDevRel
Copy link
Member

Thanks for pointing this out @0xthorazine , would you like to fix this issue and submit a PR? pls let me know so I can assign you this issue
this is the correct link https://docs.web3js.org/guides/advanced/tree_shaking

@SantiagoDevRel SantiagoDevRel added Documentation Relates to project wiki or documentation 4.x 4.0 related Good First Issue Great to learn the internals of web3.js labels Feb 16, 2024
@SantiagoDevRel
Copy link
Member

Oh I just saw ur PR, thanks @0xthorazine

@kaksv
Copy link

kaksv commented Feb 16, 2024

@SantiagoDevRel , Is the issue already solved? OR It is yet to be assigned?

@SantiagoDevRel
Copy link
Member

Hey @kaksv , yeah this was already solved, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Documentation Relates to project wiki or documentation Good First Issue Great to learn the internals of web3.js
Projects
None yet
Development

No branches or pull requests

4 participants