New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Black bg of the logos #14
Comments
Good First IssueThis looks something that can be fixed by first time contributors to this repository. If you have already made a contribution to this project, please reserve this issue for a new contributor. Here are the steps to resolve this issue:
If you have any questions about how to resolve this issue, or about the contributing process in general, feel free to ask us. |
I'm not sure what the actual issue is. Is it that Monex Ventures supposed to have a black background, or every image with a black backgroud should have a transparent one? |
@sirinoks, @vinzvinci is gonna upload some files here soon, you just gotta replace the existing files in the public/assets dir with the new ones |
Oh, lol, okay. It's barely any work at all :o |
@sirinoks Do you want to work on this? I'll assign you 🙂 |
@krishguptadev Yes! |
https://www.figma.com/file/rmCKKIsjSWCH0q6lObDQC8/Dev-Protocol-design?node-id=0%3A1 Hi, do u think it is possible to get the image here @sirinoks? As of now, I don't have their files. |
@vinzvinci I could get these images correctly from the file: |
I think it better to follow the background color here to fix this issue |
I applied the color that was present in the design, ie light gray not sure what could we change more? |
Wdym? I think it didn't apply yet. The bg shows black. Pls change it to #E5E5E5 |
Idt that tailwind styles don't apply: https://github.com/web3community/devprotocol.xyz/blob/main/src/pages/index.astro#L63 |
How about bg-gray-200? |
Doesn't make a change, All images have that black bg... afaik |
That's weird, try to use a white background for awhile. |
Thanks for checking @krishguptadev. Photoshop can do this xD. |
Done in 6a89e35 |
Great! Thank you for your contribution ✨ |
Please check #30 (comment) |
The text was updated successfully, but these errors were encountered: