Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Black bg of the logos #14

Closed
gptkrsh opened this issue Oct 6, 2021 · 21 comments · Fixed by #30
Closed

[BUG]: Black bg of the logos #14

gptkrsh opened this issue Oct 6, 2021 · 21 comments · Fixed by #30
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@gptkrsh
Copy link

gptkrsh commented Oct 6, 2021

image

@gptkrsh gptkrsh added the good first issue Good for newcomers label Oct 6, 2021
@gptkrsh
Copy link
Author

gptkrsh commented Oct 6, 2021

Good First Issue

This looks something that can be fixed by first time contributors to this repository. If you have already made a contribution to this project, please reserve this issue for a new contributor.

Here are the steps to resolve this issue:

  • Find the files uploaded to this issue's comments
  • Replace them with the current images
  • Open a PR

If you have any questions about how to resolve this issue, or about the contributing process in general, feel free to ask us.

@gptkrsh gptkrsh added bug Something isn't working hacktoberfest help wanted Extra attention is needed labels Oct 6, 2021
@gptkrsh gptkrsh added this to To do in Initial Release via automation Oct 6, 2021
@sirinoks
Copy link
Contributor

sirinoks commented Oct 6, 2021

I'm not sure what the actual issue is. Is it that Monex Ventures supposed to have a black background, or every image with a black backgroud should have a transparent one?

@gptkrsh
Copy link
Author

gptkrsh commented Oct 6, 2021

@sirinoks, @vinzvinci is gonna upload some files here soon, you just gotta replace the existing files in the public/assets dir with the new ones

@sirinoks
Copy link
Contributor

sirinoks commented Oct 6, 2021

Oh, lol, okay. It's barely any work at all :o

@gptkrsh
Copy link
Author

gptkrsh commented Oct 6, 2021

@sirinoks Do you want to work on this? I'll assign you 🙂

@sirinoks
Copy link
Contributor

sirinoks commented Oct 6, 2021

@krishguptadev Yes!

@gptkrsh gptkrsh moved this from To do to In progress in Initial Release Oct 7, 2021
@vinzvinci
Copy link
Member

https://www.figma.com/file/rmCKKIsjSWCH0q6lObDQC8/Dev-Protocol-design?node-id=0%3A1

Hi, do u think it is possible to get the image here @sirinoks? As of now, I don't have their files.

@gptkrsh
Copy link
Author

gptkrsh commented Oct 7, 2021

@vinzvinci I could get these images correctly from the file:

monexventures
msstartups

@vinzvinci
Copy link
Member

I think it better to follow the background color here to fix this issue

image

@gptkrsh
Copy link
Author

gptkrsh commented Oct 7, 2021

I think it better to follow the background color here to fix this issue

image

I applied the color that was present in the design, ie light gray not sure what could we change more?

@vinzvinci
Copy link
Member

Wdym?

I think it didn't apply yet. The bg shows black. Pls change it to #E5E5E5

@gptkrsh
Copy link
Author

gptkrsh commented Oct 7, 2021

@vinzvinci
Copy link
Member

vinzvinci commented Oct 7, 2021

How about bg-gray-200?

@gptkrsh
Copy link
Author

gptkrsh commented Oct 7, 2021

How about bg-gray-200?

Doesn't make a change, All images have that black bg... afaik

@vinzvinci
Copy link
Member

That's weird, try to use a white background for awhile.

@gptkrsh
Copy link
Author

gptkrsh commented Oct 7, 2021

That's weird, try to use a white background for awhile.

For testing purposes I have edited the html inside the browser, check this. It doesn't affect the stuff since the images possess the dark gray bg, the section doesn't:
image

@vinzvinci
Copy link
Member

vinzvinci commented Oct 7, 2021

Thanks for checking @krishguptadev. Photoshop can do this xD.

@vinzvinci
Copy link
Member

vinzvinci commented Oct 7, 2021

hashub

miraise

monexventures

msstartups

sios

here you go.

@sirinoks
Copy link
Contributor

sirinoks commented Oct 7, 2021

Done in 6a89e35
Thank you for an opportunity!

@shuklaritvik06
Copy link
Member

Done in 6a89e35
Thank you for an opportunity!

Great! Thank you for your contribution ✨

@vinzvinci
Copy link
Member

Please check #30 (comment)

@gptkrsh gptkrsh linked a pull request Oct 8, 2021 that will close this issue
Initial Release automation moved this from In progress to Done Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

4 participants