Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random & Android #146

Closed
ligi opened this issue Jul 27, 2017 · 3 comments
Closed

Random & Android #146

ligi opened this issue Jul 27, 2017 · 3 comments

Comments

@ligi
Copy link
Contributor

ligi commented Jul 27, 2017

As Web3j is also intended to be used on Android - a secure random implementation should be used like:
https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/crypto/LinuxSecureRandom.java

also see:
https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/core/ECKey.java#L136

and:

https://android-developers.googleblog.com/2013/08/some-securerandom-thoughts.html
@conor10
Copy link
Contributor

conor10 commented Aug 1, 2017

Thanks for highlighting this @ligi, much appreciated.

conor10 added a commit that referenced this issue Sep 13, 2017
@conor10
Added secure random implementation for Android (#146).
c8a1dc5
@conor10
Copy link
Contributor

conor10 commented Sep 13, 2017

Done.

@conor10 conor10 closed this as completed Sep 13, 2017
@ligi
Copy link
Contributor Author

ligi commented Sep 13, 2017

thanks!

@ligi ligi mentioned this issue Sep 13, 2017
Closed
franz-see pushed a commit to franz-see/web3j that referenced this issue Aug 3, 2018
@conor10
Added secure random implementation for Android (hyperledger#146).
56ac433
denis554 added a commit to denis554/web3j that referenced this issue Mar 27, 2019
@denis554
Added secure random implementation for Android (hyperledger/web3j#146).
2242275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ligi @conor10