Fix Integration Tests #1294
Merged
Fix Integration Tests #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
approved these changes
Nov 24, 2020
integration-tests/src/test/java/org/web3j/protocol/besu/BesuOnChainPrivacyIntegrationTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/protocol/parity/ParityIT.java
Outdated
Show resolved
Hide resolved
xaviarias
suggested changes
Nov 25, 2020
integration-tests/src/test/java/org/web3j/protocol/besu/BesuOnChainPrivacyIntegrationTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/generated/Fibonacci.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/generated/Fibonacci.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/protocol/core/TestnetConfig.java
Show resolved
Hide resolved
xaviarias
suggested changes
Dec 2, 2020
codegen/src/main/java/org/web3j/codegen/unit/gen/CompilerClassLoader.java
Outdated
Show resolved
Hide resolved
codegen/src/test/java/org/web3j/codegen/SolidityFunctionWrapperTest.java
Outdated
Show resolved
Hide resolved
codegen/src/test/java/org/web3j/codegen/unit/gen/java/Setup.java
Outdated
Show resolved
Hide resolved
codegen/src/test/java/org/web3j/codegen/unit/gen/kotlin/Setup.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/protocol/besu/BesuOnChainPrivacyIntegrationTest.java
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/protocol/besu/BesuOnChainPrivacyIntegrationTest.java
Show resolved
Hide resolved
integration-tests/src/test/java/org/web3j/protocol/core/TestnetConfig.java
Outdated
Show resolved
Hide resolved
|
Also we should mention in the README to configure the Docker client with |
rach-id
approved these changes
Dec 2, 2020
codegen/src/test/java/org/web3j/codegen/SolidityFunctionWrapperGeneratorTest.java
Show resolved
Hide resolved
codegen/src/test/java/org/web3j/codegen/SolidityFunctionWrapperGeneratorTest.java
Outdated
Show resolved
Hide resolved
codegen/src/test/java/org/web3j/codegen/SolidityFunctionWrapperTest.java
Outdated
Show resolved
Hide resolved
Wrappers will be generated only if the sol file is provided.
xaviarias
approved these changes
Dec 2, 2020
rach-id
pushed a commit
to rach-id/web3j
that referenced
this pull request
Dec 10, 2021
* Initial Commit. * Initial IT Commit * CoreIT test fixes * 80% of Scenarios pass. * Fixed more tests. * All tests are passing Clean up * Applied feedback * Wrappers are now generated with every build of codegen * Removed primitive contract. There is not use for it * Fixed failing test. Wrappers will be generated only if the sol file is provided.
rach-id
pushed a commit
to rach-id/web3j
that referenced
this pull request
Dec 10, 2021
* Initial Commit. * Initial IT Commit * CoreIT test fixes * 80% of Scenarios pass. * Fixed more tests. * All tests are passing Clean up * Applied feedback * Wrappers are now generated with every build of codegen * Removed primitive contract. There is not use for it * Fixed failing test. Wrappers will be generated only if the sol file is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use Web3j-Unit to fix the integration tests
Where should the reviewer start?
Changed Files
Why is it needed?
So the integration tests can run