Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yParity for Geth compatibility #1959

Merged
merged 1 commit into from Sep 6, 2023
Merged

add yParity for Geth compatibility #1959

merged 1 commit into from Sep 6, 2023

Conversation

gtebrean
Copy link
Contributor

@gtebrean gtebrean commented Sep 5, 2023

What does this PR do?

Fixes #1951

Where should the reviewer start?

required

Why is it needed?

for Geth compatibility

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1959 (efeb2ba) into master (f6a2aed) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1959      +/-   ##
============================================
+ Coverage     68.15%   68.36%   +0.21%     
- Complexity     2986     2992       +6     
============================================
  Files           488      488              
  Lines         12501    12510       +9     
  Branches       1627     1631       +4     
============================================
+ Hits           8520     8553      +33     
+ Misses         3507     3482      -25     
- Partials        474      475       +1     
Files Changed Coverage Δ
...web3j/protocol/core/methods/response/EthBlock.java 92.23% <ø> (ø)
...3j/protocol/core/methods/response/Transaction.java 95.45% <100.00%> (+11.33%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtebrean gtebrean merged commit e4e1dd7 into master Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incompatibility with Geth 1.12.1 concerning yParity
2 participants