Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dynamic Arrays encode #1961

Merged
merged 3 commits into from
Sep 19, 2023
Merged

fix Dynamic Arrays encode #1961

merged 3 commits into from
Sep 19, 2023

Conversation

gtebrean
Copy link
Contributor

@gtebrean gtebrean commented Sep 12, 2023

What does this PR do?

Fixes #1949

Where should the reviewer start?

required

Why is it needed?

Case wasn't covered until now and we found out is not working properly.

@cfelde
Copy link
Contributor

cfelde commented Sep 12, 2023

LGTM, but should be also ensure we can decode this, i.e., any changes needed to TypeDecoder for example?

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1961 (a426d7d) into master (e4e1dd7) will increase coverage by 0.07%.
The diff coverage is 82.60%.

@@             Coverage Diff              @@
##             master    #1961      +/-   ##
============================================
+ Coverage     68.38%   68.46%   +0.07%     
- Complexity     2993     3001       +8     
============================================
  Files           488      488              
  Lines         12510    12550      +40     
  Branches       1631     1636       +5     
============================================
+ Hits           8555     8592      +37     
- Misses         3481     3482       +1     
- Partials        474      476       +2     
Files Changed Coverage Δ
abi/src/main/java/org/web3j/abi/TypeDecoder.java 75.49% <78.12%> (+0.65%) ⬆️
abi/src/main/java/org/web3j/abi/TypeEncoder.java 94.58% <80.00%> (-0.45%) ⬇️
abi/src/main/java/org/web3j/abi/Utils.java 80.53% <100.00%> (+1.25%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cfelde cfelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtebrean gtebrean merged commit 2a2da15 into master Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to encode struct[][]
3 participants