Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate baseFeePerBlobGas value #2006

Merged
merged 3 commits into from Feb 20, 2024
Merged

Calculate baseFeePerBlobGas value #2006

merged 3 commits into from Feb 20, 2024

Conversation

NickSneo
Copy link
Contributor

What does this PR do?

Add a new feature to get baseFeePerBlobGas value

Where should the reviewer start?

review all files, start with BlobFee.java file

Why is it needed?

required

Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (86c987d) 68.94% compared to head (ede5e8b) 69.20%.
Report is 2 commits behind head on master.

Files Patch % Lines
...web3j/protocol/core/methods/response/EthBlock.java 82.45% 6 Missing and 4 partials ⚠️
.../java/org/web3j/protocol/core/JsonRpc2_0Web3j.java 88.88% 2 Missing ⚠️
...ocol/core/methods/response/TransactionReceipt.java 94.11% 2 Missing ⚠️
...3j/protocol/core/methods/response/Transaction.java 97.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2006      +/-   ##
============================================
+ Coverage     68.94%   69.20%   +0.25%     
- Complexity     3089     3117      +28     
============================================
  Files           493      493              
  Lines         12922    13078     +156     
  Branches       1661     1688      +27     
============================================
+ Hits           8909     9050     +141     
- Misses         3526     3537      +11     
- Partials        487      491       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GrapeBaBa
Copy link

which version will include this feature?

@NickSneo
Copy link
Contributor Author

which version will include this feature?

We will be releasing it in next release 4.11.1

Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo NickSneo marked this pull request as ready for review February 19, 2024 22:12
@cfelde
Copy link
Contributor

cfelde commented Feb 20, 2024

LGTM

@NickSneo NickSneo merged commit b54cfa4 into master Feb 20, 2024
6 checks passed
@NickSneo NickSneo deleted the nicks/blobBaseFee branch February 20, 2024 12:16
@GrapeBaBa
Copy link

which version will include this feature?

We will be releasing it in next release 4.11.1

When will 4.11.1 release? We need 4844 support Dencun upgrade.

@NickSneo
Copy link
Contributor Author

which version will include this feature?

We will be releasing it in next release 4.11.1

When will 4.11.1 release? We need 4844 support Dencun upgrade.

Should be complete by next week, we need to add other things in web3j-cli and want to release everything together. Also since web3j is now migrating to Hyperledger web3j, we will be making changes to all the repo and include it in 4.11.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants