fix contract generator #2017
Merged
fix contract generator #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2017 +/- ##
============================================
+ Coverage 69.20% 69.22% +0.01%
- Complexity 3122 3123 +1
============================================
Files 493 493
Lines 13145 13145
Branches 1695 1695
============================================
+ Hits 9097 9099 +2
+ Misses 3557 3556 -1
+ Partials 491 490 -1 ☔ View full report in Codecov by Sentry. |
|
Looks good but curious - what is the things that is broken without this change? |
will brake the generation of test contract wrappers....atm every method needs to be public in order for unit tests to be created properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix contract wrapper generation
Where should the reviewer start?
required
Why is it needed?
required