Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More effective implementation of MnemonicUtils.generateEntropy #665

Merged
merged 1 commit into from Oct 22, 2018

Conversation

serso
Copy link
Contributor

@serso serso commented Aug 7, 2018

It doesn't manipulate with strings that much as the old version.
Instead it uses a BitSet.

Also, some static tests for MnemonicUtils.generateEntropy were added in
this commit.

It doesn't manipulate with strings that much as the old version.
Instead it uses a BitSet.

Also, some static tests for MnemonicUtils.generateEntropy were added in
this commit.
@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #665 into release/4.0 will increase coverage by 0.25%.
The diff coverage is 80%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/4.0     #665      +/-   ##
=================================================
+ Coverage          76.76%   77.01%   +0.25%     
+ Complexity          1798     1795       -3     
=================================================
  Files                239      239              
  Lines               6713     6661      -52     
  Branches            1004      998       -6     
=================================================
- Hits                5153     5130      -23     
+ Misses              1304     1281      -23     
+ Partials             256      250       -6
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/org/web3j/crypto/MnemonicUtils.java 78.3% <80%> (-0.6%) 34 <8> (+2)
...a/org/web3j/protocol/websocket/events/NewHead.java 13.33% <0%> (+0.83%) 2% <0%> (ø) ⬇️
...ava/org/web3j/codegen/SolidityFunctionWrapper.java 95.94% <0%> (+2.05%) 114% <0%> (-5%) ⬇️
core/src/main/java/org/web3j/tx/Contract.java 75.67% <0%> (+6.44%) 46% <0%> (ø) ⬇️
.../org/web3j/protocol/websocket/WebSocketClient.java 80% <0%> (+7.27%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa91725...0c71552. Read the comment docs.

@snazha-blkio snazha-blkio changed the base branch from master to release/4.0 October 18, 2018 20:38
@snazha-blkio snazha-blkio added this to the 4.0 milestone Oct 18, 2018
@snazha-blkio snazha-blkio merged commit cf7baa5 into hyperledger:release/4.0 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants