Feature/long chainId #913
Merged
Feature/long chainId #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated methods with byte chainId in favour of those with long chainId
… a Bip39 wallet using a known mnemonic.
snazha-blkio
added
merge-to-android
awaiting-android-release
and removed
awaiting-android-release
merge-to-android
labels
|
This pull request has been mentioned on Web3 Labs Community. There might be relevant details there: https://community.web3labs.com/t/web3j-android-branch-harmonisation-with-master/24/6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #905
What does this PR do?
Allows users of Web3j to set a chainId greater than 255.
Where should the reviewer start?
This change includes 2 commits:
A piece of work conducted in e-Contract whereby Signature is updated to use a byte array for "V".
(e-Contract@6b70484)
TransactionEncoder to accept chainId as a long (and update chain constants from byte to long).
Why is it needed?
Developers working with private chains (which theoretically have a chain ID greater than 1337) are unable to use web3j to sign transactions bound for their web3 provider.
Thanks to @rain-on for initial PR