You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, here's a feature request I had and would be happy to work on with some input from the team. Thanks for any help that can be provided.
Context
In WalletModdal/config.ts, there is a hard-coded array of elements that are used for rendering all of the Wallet-specific UI elements in the modal.
While I was working on an application, I wanted to be able to explicitly configure which providers were "valid" for my application; basically, I didn't want to give a user of my application the impression that Safepal was supported to the same degree that, e.g., Metamask is.
Proposal
Continue to use the hard-coded array by default, but allow the user to pass in a connectors prop, which overrides the hardcoded list; the connectors prop would be an array of the same type as the existing connectors variable
While this solves my issue, it creates a UX problem, which is that if a user passes in an odd number of wallet configurations, then they will get a wallet that has one "empty" grid cell. If that's enough of a problem for a consumer, there are ways to fix it, but I'd probably need some design input on how to handle that case.
For example, one way to solve it would be to make the odd element span the entire width of the container, but I think this would require changing GridStyled to be display:flex instead of display:grid, and would also require changes to its children.
Questions
Does allowing wallets to be configurable by a consumer make sense?
If so, how do you suggest handling the case of an odd number of wallet configs? Do nothing? My suggestion above? Something else?
The text was updated successfully, but these errors were encountered:
Hi @jhhb thanks for taking an interest in the kit.
Sure, I think this sounds like a nice feature and we always welcome open source contributions to the kit. In and for the flex vs grid question I think the desired UI is achievable with both but whatever solution you prefer is fine with me.
Ping me when you complete the pull request and i'll glad review it for you =]
Hello, here's a feature request I had and would be happy to work on with some input from the team. Thanks for any help that can be provided.
Context
Proposal
connectors
prop, which overrides the hardcoded list; theconnectors
prop would be an array of the same type as the existingconnectors
variableWhile this solves my issue, it creates a UX problem, which is that if a user passes in an odd number of wallet configurations, then they will get a wallet that has one "empty" grid cell. If that's enough of a problem for a consumer, there are ways to fix it, but I'd probably need some design input on how to handle that case.
For example, one way to solve it would be to make the odd element span the entire width of the container, but I think this would require changing GridStyled to be
display:flex
instead ofdisplay:grid
, and would also require changes to its children.Questions
The text was updated successfully, but these errors were encountered: