Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

fix(Nav): make Nav can be collapsed after clicked item #271

Merged
merged 2 commits into from
May 9, 2020

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented May 8, 2020

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

Gif:

auto-close-nav

@Kimi-Gao Kimi-Gao linked an issue May 8, 2020 that may be closed by this pull request
@Kimi-Gao Kimi-Gao self-assigned this May 8, 2020
@Kimi-Gao Kimi-Gao added the PR: fix A bug fix label May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #271 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   17.81%   17.86%   +0.05%     
==========================================
  Files          71       71              
  Lines        1398     1399       +1     
  Branches      313      314       +1     
==========================================
+ Hits          249      250       +1     
  Misses        882      882              
  Partials      267      267              
Impacted Files Coverage Δ
src/components/Nav/Nav.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f42a87...5361244. Read the comment docs.

@Kimi-Gao Kimi-Gao merged commit 7748b67 into master May 9, 2020
@Kimi-Gao Kimi-Gao deleted the auto-close-nav branch May 9, 2020 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nav] can collapse automatically when click nav item
1 participant