Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(Button): add htmlType prop for form submit button #278

Merged
merged 1 commit into from
May 16, 2020

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented May 16, 2020

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Relative issue:

Description:

ScreenShots:

Gif:

@Kimi-Gao Kimi-Gao added the PR: feat A new feature label May 16, 2020
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   17.86%   17.86%           
=======================================
  Files          71       71           
  Lines        1399     1399           
  Branches      314      314           
=======================================
  Hits          250      250           
  Misses        882      882           
  Partials      267      267           
Impacted Files Coverage Δ
src/components/Button/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8450a5...941bfa6. Read the comment docs.

@Kimi-Gao Kimi-Gao self-assigned this May 16, 2020
@Kimi-Gao Kimi-Gao merged commit 03fbf72 into master May 16, 2020
@Kimi-Gao Kimi-Gao deleted the button-htmlType branch May 16, 2020 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant