Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(Button): add accept warning and danger button type #40

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented Jan 26, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Relative issue:

#37

Description:

  1. Adjust secondary button's background-color when hovering.
  2. Add accept warning and danger button type.

ScreenShots:

image

@Kimi-Gao Kimi-Gao self-assigned this Jan 26, 2019
@Kimi-Gao Kimi-Gao changed the title Buttons feat(Button): add accept warning and danger button type Jan 26, 2019
@Kimi-Gao Kimi-Gao changed the base branch from feature-0.4 to master January 26, 2019 08:22
@Kimi-Gao Kimi-Gao changed the base branch from master to feature-0.4 January 26, 2019 08:23
@Kimi-Gao Kimi-Gao requested a review from goroyal January 26, 2019 12:52
@Kimi-Gao Kimi-Gao merged commit fc14984 into feature-0.4 Jan 27, 2019
@Kimi-Gao Kimi-Gao deleted the buttons branch January 27, 2019 14:23
@Kimi-Gao Kimi-Gao added PR: feat A new feature and removed type: ADD labels Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants