Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(aside): add aside and refactor basic dialog by react portal #45

Merged
merged 16 commits into from
Feb 28, 2019

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented Feb 27, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Relative issue:

#39

Description:

  1. Add Aside component and support stacking asides
  2. Refactor dialog and notification component cuz using React portal

Gif:

feb-27-2019 14-14-40

Stacking Asides Design:

image

@Kimi-Gao Kimi-Gao added the PR: feat A new feature label Feb 27, 2019
@Kimi-Gao Kimi-Gao self-assigned this Feb 27, 2019
@Kimi-Gao Kimi-Gao merged commit 6163fb4 into feature-0.4 Feb 28, 2019
@Kimi-Gao Kimi-Gao deleted the basic-aside branch February 28, 2019 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants