Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(button): add loading attribute to button to initialize a spinner #76

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented Sep 20, 2019

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Relative issue:
re #61

Description:

  • Upgrade react/dom/min to latest cuz hooks need.
  • Add loading style to button
  • Click event will be invalid when button is loading
  • Remove unused prop circle

Gif:
loading-button

@Kimi-Gao Kimi-Gao self-assigned this Sep 20, 2019
@Kimi-Gao Kimi-Gao added the PR: feat A new feature label Sep 20, 2019
@Kimi-Gao Kimi-Gao added this to Reviewing in earth-ui@0.6.x via automation Sep 20, 2019
@Kimi-Gao Kimi-Gao added this to the earth-ui@0.6.x milestone Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   10.84%   10.84%           
=======================================
  Files          70       70           
  Lines        1411     1411           
  Branches      322      322           
=======================================
  Hits          153      153           
  Misses        964      964           
  Partials      294      294
Impacted Files Coverage Δ
src/components/Button/index.js 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37724e5...f9e9616. Read the comment docs.

@Kimi-Gao Kimi-Gao merged commit 221b0c5 into master Sep 30, 2019
earth-ui@0.6.x automation moved this from In progress (PR) to Done (PR) Sep 30, 2019
@Kimi-Gao Kimi-Gao deleted the loading-btn branch September 30, 2019 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: feat A new feature
Projects
No open projects
earth-ui@0.6.x
  
Done (PR)
Development

Successfully merging this pull request may close these issues.

None yet

1 participant