Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(input): add new input component #77

Merged
merged 21 commits into from
Oct 10, 2019
Merged

feat(input): add new input component #77

merged 21 commits into from
Oct 10, 2019

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented Oct 1, 2019

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Relative issue:

re #62

Description:

ScreenShots:
image

Gif:

@Kimi-Gao Kimi-Gao added PR: feat A new feature status: in progress Working in progress labels Oct 1, 2019
@Kimi-Gao Kimi-Gao self-assigned this Oct 1, 2019
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #77 into master will increase coverage by 4.71%.
The diff coverage is 74.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   10.84%   15.55%   +4.71%     
==========================================
  Files          70       69       -1     
  Lines        1411     1414       +3     
  Branches      322      321       -1     
==========================================
+ Hits          153      220      +67     
+ Misses        964      912      -52     
+ Partials      294      282      -12
Impacted Files Coverage Δ
src/components/Form/FormInput/index.js 0% <0%> (ø) ⬆️
src/components/Select/Select/index.js 0% <0%> (ø) ⬆️
src/components/Input/index.js 97.22% <96.96%> (+97.22%) ⬆️
src/components/Popover/CoordinateFactory.js 2.22% <0%> (+2.22%) ⬆️
src/components/Popover/PopoverContent.js 13.33% <0%> (+13.33%) ⬆️
src/components/Popover/index.js 23.17% <0%> (+23.17%) ⬆️
src/components/Tooltip/index.js 100% <0%> (+100%) ⬆️
src/components/_utils/omit.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2712b67...758bb3f. Read the comment docs.

@Kimi-Gao Kimi-Gao added this to In progress (PR) in earth-ui@0.7.x via automation Oct 1, 2019
@Kimi-Gao Kimi-Gao added this to the earth-ui@0.7.x milestone Oct 1, 2019
@Kimi-Gao Kimi-Gao removed the status: in progress Working in progress label Oct 8, 2019
@Kimi-Gao Kimi-Gao merged commit 653de93 into master Oct 10, 2019
earth-ui@0.7.x automation moved this from In progress (PR) to Done (PR) Oct 10, 2019
@Kimi-Gao Kimi-Gao deleted the basic-input branch October 10, 2019 05:31
@Kimi-Gao Kimi-Gao removed this from the earth-ui@0.7.x milestone Feb 10, 2020
@Kimi-Gao Kimi-Gao linked an issue Feb 10, 2020 that may be closed by this pull request
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: feat A new feature
Projects
No open projects
earth-ui@0.7.x
  
Done (PR)
Development

Successfully merging this pull request may close these issues.

[Input] Add basic input component in form
2 participants