Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

feat(Nav): make setting button can be hidden #279

Merged
merged 1 commit into from
May 17, 2020
Merged

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented May 17, 2020

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Add some descriptions and refer relative issues(optional) for your PR.
  • Add Assignees(assign yourself mostly) for your PR.
  • Add Labels for your PR.

Extra checklist:

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Add unit tests for the feature.

Relative issue:

Description:

ScreenShots:

Gif:

@Kimi-Gao Kimi-Gao self-assigned this May 17, 2020
@Kimi-Gao Kimi-Gao added the PR: feat A new feature label May 17, 2020
@Kimi-Gao Kimi-Gao merged commit e9e121b into master May 17, 2020
@Kimi-Gao Kimi-Gao deleted the hide-setting branch May 17, 2020 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant