Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.2 breaks ember-inspector component inspector #274

Closed
XuluWarrior opened this issue Feb 23, 2018 · 4 comments
Closed

0.6.2 breaks ember-inspector component inspector #274

XuluWarrior opened this issue Feb 23, 2018 · 4 comments

Comments

@XuluWarrior
Copy link
Contributor

Changes in c016731 made mixins/style-namespacing-extras.js an empty mixin.

When inspecting a component using the magnifying glass and clicking on the component name, this causes a call stack in ember-inspector in propertiesForMixin(mixin) where it expects all mixins to have a mixins array.

You can see the behaviour when running https://github.com/XuluWarrior/ember-component-css-test

@webark
Copy link
Owner

webark commented Feb 23, 2018

@XuluWarrior is that fixed if we just pass in an empty to the mixin? if you could issue a PR that would be awesome!! Otherwise I'll look at it a little later.

@XuluWarrior
Copy link
Contributor Author

I can try that.

I haven't looked in any depth, but I was wondering, if the mixin is empty, is it needed?

@XuluWarrior
Copy link
Contributor Author

Passing empty in to the mixin fixes the issue with ember-inspector

@webark
Copy link
Owner

webark commented Feb 26, 2018

@XuluWarrior 0.6.3 has been released with this fix. Thanks for the PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants