Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdDSA Support #145

Open
wparad opened this issue Nov 6, 2023 · 4 comments
Open

EdDSA Support #145

wparad opened this issue Nov 6, 2023 · 4 comments

Comments

@wparad
Copy link
Contributor

wparad commented Nov 6, 2023

I'm looking for EdDSA support: https://github.com/webauthn-open-source/fido2-lib/blob/master/lib/keyUtils.js#L161

Is there something stopping this? Or really, what was the reason this was disabled (There was actually enabled for some time and then disabled)

@JamesCullum
Copy link
Member

@Hexagon Can you clarify why you disabled EdDSA before? Can this be re-enabled?

In every case, we will need a test case for this - apart from that, we should be good.

@Hexagon
Copy link
Member

Hexagon commented Nov 6, 2023

👋

I don't think EdDSA has ever worked (?). I added skeleton support in this commit to aid future development - but it is untested, and I'm not sure the implementation of Web Cryptography API in Deno and Node supports it without enabling experimental flags yet.

So, this is in need of further investigation and tests to cover. Up for grabs!

@JamesCullum
Copy link
Member

Thanks for the quick response and great insight - so if anyone can make a test case, we can turn it on 👍

@vikinatora
Copy link

Our team is also interested in this feature. Unfortuantely, I believe we can't contribute it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants