Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind API is bad #3669

Open
avaer opened this issue Aug 28, 2022 · 1 comment
Open

Wind API is bad #3669

avaer opened this issue Aug 28, 2022 · 1 comment
Assignees

Comments

@avaer
Copy link
Contributor

avaer commented Aug 28, 2022

This API convention doesn't follow any of the React, metaversefile, or Webaverse conventions:

  getWinds() {
    return world.winds;
  },
  setWinds(wind) {
    world.winds.push(wind);
  },
  removeWind(wind) {
    const index = world.winds.indexOf(wind);
    if (index > -1) {
      world.winds.splice(index, 1);
    }
   },
@avaer
Copy link
Contributor Author

avaer commented Aug 28, 2022

This probably requires totum updates.

@tcm390 tcm390 self-assigned this Aug 28, 2022
This was referenced Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants