Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement account forget #5

Open
sushi30 opened this issue Jun 4, 2021 · 3 comments
Open

Implement account forget #5

sushi30 opened this issue Jun 4, 2021 · 3 comments

Comments

@sushi30
Copy link

sushi30 commented Jun 4, 2021

Description

This command, according to the docs, should remove an account from local memory:

forget      Remove/Forget an account

This is obviously useful form local testing scenarios but also in production for sweeping accounts.

Scenario

When using this command:

$  webb account forget

Output:

thread 'main' panicked at 'not yet implemented: forget account', src/commands/account.rs:186:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected

Delete the account by alias or by address.

Proposed Solution

I saw this is not yet implemented so I will take this and implement if no one minds.

@drewstone
Copy link

Awesome! Can you describe more deeply the issue and link to the description you saw as unimplemented?

It would be great to ensure the CLI works against the master, develop, and erup-4 branches. These are the ones we are currently working on in parallel. master and develop are explanatory. erup-4 is targeting the Edgeware Runtime Upgrade Proposal #4 that will add this runtime functionality to the Edgeware blockchain.

@sushi30
Copy link
Author

sushi30 commented Jun 6, 2021

Hi, added some more meaningful description. Let me know if you need any more information.

@drewstone
Copy link

Awesome sounds good! I'd also recommend testing to make sure this CLI works against master and erup-4 branches of the anon node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants