Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Finish transactWrap/Unwrap flow with new token parameter on ExtData #254

Open
drewstone opened this issue Sep 3, 2022 · 1 comment
Open

[TASK] Finish transactWrap/Unwrap flow with new token parameter on ExtData #254

drewstone opened this issue Sep 3, 2022 · 1 comment
Labels
p2 🟡 Issue should be resolved soon task ✔️

Comments

@drewstone
Copy link
Contributor

Issue summary
Still need to augment the extrinsic to support conditional wrap/unwrap when there is a valid token. We will use the largest T::AssetId to indicate NO unwrapping, i.e.:

  • If token is T::AssetId::MAX() it means ONLY transact.
  • If token is 0 it means native unwrapping.
  • If token is non-zero it means non-native unwrapping.
@drewstone drewstone self-assigned this Sep 3, 2022
@dutterbutter dutterbutter added p2 🟡 Issue should be resolved soon task ✔️ labels Sep 8, 2022
@dutterbutter
Copy link
Contributor

@drewstone is this completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2 🟡 Issue should be resolved soon task ✔️
Projects
Webb Universe
Status: Not Started 🕧
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewstone @dutterbutter