Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Expose fields getter for Note inner JsNote #244

Open
AhmedKorim opened this issue Jun 16, 2022 · 0 comments
Open

[TASK] Expose fields getter for Note inner JsNote #244

AhmedKorim opened this issue Jun 16, 2022 · 0 comments
Labels
p3 🔵 Issues should be resolved eventually spec 🆕 Specification details for future implementation

Comments

@AhmedKorim
Copy link
Contributor

AhmedKorim commented Jun 16, 2022

Overview

The current Note class doesn't expose the inner JsNote fields, to reach those data the user has to access the inner type
The goal here is to expose the inner type fields

Spec

Fields to expose

Fields are defined in the inner type JsNote after building packages/wasm-utils/build/wasm-utils.d.ts

Getters

 get HashFunction () {
   return this.note.hashFunction ;
 }
 

for importing types from wasm-utils use import type {xxx} from '@webb-tools/wasm-utils
EX import type {HashFunction} from '@webb-tools/wasm-utils'

Tests

Similar to the tests we have in the note.spec.ts packages/sdk-core/src/__test__/note.spec.ts, Add a test that leverages those getters and insure that the values are correct

@AhmedKorim AhmedKorim changed the title [TASK] Expose fields for Note inner JSNote [TASK] Expose fields getter for Note inner JsNote Jun 16, 2022
@AhmedKorim AhmedKorim added the spec 🆕 Specification details for future implementation label Jun 20, 2022
@dutterbutter dutterbutter added the p3 🔵 Issues should be resolved eventually label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 🔵 Issues should be resolved eventually spec 🆕 Specification details for future implementation
Projects
Status: Not Started 🕧
Development

No branches or pull requests

3 participants