Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate cache for https #43

Closed
ajaydsouza opened this issue Oct 27, 2015 · 4 comments
Closed

Separate cache for https #43

ajaydsouza opened this issue Oct 27, 2015 · 4 comments
Labels
Milestone

Comments

@ajaydsouza
Copy link
Contributor

Using the same cache for https and http causes potential conflicts at times, especially when the SSL certificate is not validated.

Also, you don't want to show http links when a user is on an https page

@mikeyzm
Copy link

mikeyzm commented May 18, 2017

Is there any plan to improve caching?

I think SQL query results should be cached instead of entire HTML.

@ajaydsouza
Copy link
Contributor Author

The reason for caching the entire HTML is to speed it up completely.

The SQL results will make my life a bit easier though, I must admit when dealing with different pages. My idea is to still use the HTML but use different keys based on settings

@mikeyzm
Copy link

mikeyzm commented May 24, 2017

There is negligible performance loss when generate HTML dynamically using PHP. Cache SQL results can make it become more flexible, more filters can be added and close this issue.

Please consider my suggestion, and I'd like to help.

@ajaydsouza
Copy link
Contributor Author

I'm happy to take any pull requests that would implement this.

The way I think about it is:

a) Add a separate meta field to store the cache. This should start with a _ to keep it hidden from the Edit Post screen. Currently that cache doesn't use this name.
b) Add a separate option under cache settings to choose level of caching - advanced users can choose to only cache mySQL

Happy to hear suggestions to improve this.

@ajaydsouza ajaydsouza added this to the 2.7.0 milestone Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants