Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard target for new page is "_blank" #106

Closed
creativecat opened this issue Jul 25, 2013 · 5 comments
Closed

Standard target for new page is "_blank" #106

creativecat opened this issue Jul 25, 2013 · 5 comments
Assignees
Labels

Comments

@creativecat
Copy link
Contributor

"_blank" is the default selected value in the form for new pages (but "luckily" it is not saved as selected ;-) ).

@webbird
Copy link
Contributor

webbird commented Jul 30, 2013

Thought we had solved this? There's an old issue somewhere...

@webbird
Copy link
Contributor

webbird commented Jul 30, 2013

Hm, in the template, "same page" is selected.

<select name="target" id="fc_addPage_target">
<option value="_blank">{translate('New window')}</option>
<option value="_self" selected="selected">{translate('Same window')}</option>
<option value="_top">{translate('Top frame')}</option>
</select>

So it seems to be an error in the JS?

@creativecat
Copy link
Contributor Author

I'll take look on it ;-) (this evening)

@ghost ghost assigned creativecat Jul 30, 2013
@webbird
Copy link
Contributor

webbird commented Jul 30, 2013

Same problem as always: Setting "selected" using $.prop() will not be enough. You will always have to set the val()ue, too.

creativecat added a commit that referenced this issue Jul 30, 2013
Do it the right way with .prop()...
@creativecat
Copy link
Contributor Author

This is fixed - default is _self now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants