Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer: [Return] causes the installer to switch one step backwards #173

Closed
digitalbricks opened this issue Oct 3, 2013 · 7 comments
Closed
Assignees
Milestone

Comments

@digitalbricks
Copy link

If i am filling out the forms in the installer and then using the return key for confirmation, this causes the installer to go one step backwards. I noticed this on step 4 - filled out the form, pressed return and the installer jumped back to step 3. Don't know if this issue is also present on previous steps.

@webbird
Copy link
Contributor

webbird commented Oct 7, 2013

As far as I know, return triggers the first submit button in a form, which is the back button here. As this is not a promised feature, I set this to "enhancement" for some later ... well, enhancement. :)

@webbird
Copy link
Contributor

webbird commented Oct 7, 2013

Note: What happens if hitting ENTER depends on the browser.

Depending on the browser, the Enter key may only cause a form submission if the form has exactly one text field, or only when there is a submit button present.

Source: http://api.jquery.com/submit/

@ghost ghost assigned webbird Oct 7, 2013
@webbird
Copy link
Contributor

webbird commented Oct 8, 2013

I hope I've managed it, but without guarantees. The solution may conflicts with the browser's behaviour.

webbird pushed a commit that referenced this issue Oct 8, 2013
…in installer to step forward (issue #173); little fix in markup (installer -> db step); show PHP version in Backend (system information button)
@digitalbricks
Copy link
Author

Is the fix inside the package you provide on your website or only in the github repo? I just did a fresh install with the package provided on your site an the issue still exists. But i noticed that this is only on step 4 - pressing return on step 3 does nothing (thats even better than jumping one page back).

@webbird
Copy link
Contributor

webbird commented Oct 12, 2013

Yes (install/installer.js), but as I said, it depends on the browser.

    $('body').keydown(function(e) {
        if (e.keyCode == 13) {
            $('#btn_next').trigger('click');
        }
    });

You may try Firebug to see if there are any errors.

@webbird
Copy link
Contributor

webbird commented Oct 14, 2013

Just tried it with FF 24.0 on Win7, works for me.

@digitalbricks
Copy link
Author

Fixed! Thank you! (v1.0)

@webbird webbird closed this as completed Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants