Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Support for NEWS and TOPICS in Droplet.php #201

Closed
hertsch opened this issue Nov 22, 2013 · 14 comments
Closed

Missing Support for NEWS and TOPICS in Droplet.php #201

hertsch opened this issue Nov 22, 2013 · 14 comments
Assignees
Milestone

Comments

@hertsch
Copy link
Contributor

hertsch commented Nov 22, 2013

At the moment getFirstImageFromContent() check only WYSIWYG and does not support NEWS and TOPICS.

Because TOPICS are compatible to BC it should be supported.

What is about a NEWS addon for BC, I think it is needed ... there will come a solution based on extendedWYSIWYG and/or kitFramework but not within the next time.

@webbird
Copy link
Contributor

webbird commented Nov 22, 2013

We have BlackNews.

I don't like Core extensions for special modules. Next one needs it for module X, then module Y...

Better way would be to offer an API or something, similar to Droplets(Extension) and Search, where modules can register their specialized methods if needed.

@hertsch
Copy link
Contributor Author

hertsch commented Nov 22, 2013

So BlackNews should be supported.

I agree with you that an API will be the better way - we should discuss and find a solution, TOPICS needs the Open Graph support!

@webbird
Copy link
Contributor

webbird commented Nov 28, 2013

Maybe a new helper or something. Let's discuss this via Skype.

@ghost ghost assigned webbird Nov 28, 2013
@hertsch
Copy link
Contributor Author

hertsch commented Nov 29, 2013

ok.

@webbird
Copy link
Contributor

webbird commented Jun 23, 2014

Option:

A module may have a script named getfirstimage.php (or something), similar to search.php, having a function <Modulename>_getFirstImageFromContent(). The script is included automatically if available, the method is called automatically then. Result is an URI.

@hertsch
Copy link
Contributor Author

hertsch commented Jun 23, 2014

In my opionion this option is not thought out. The CMS should support Open Graph for the active social sharing and therefore the CMS by itself need a function getFirstImageFromContent() which should be able to extract the first image from the content or to deliver a default image (i.e. the website logo) - something like the Open Graph Pattern in the TemplateTools.
The module should support the Open Graph Interface of the CMS and perhaps have a script like opengraph.php which can deliver the image, title, description and canonical link.

@webbird
Copy link
Contributor

webbird commented Jun 23, 2014

Anyway, there have to be methods to get the image from the content, which depends on the module. (DB table / row etc.)

@hertsch
Copy link
Contributor Author

hertsch commented Jun 23, 2014

That's what I had mean - but don't think only at the image ... 8-)
... PageImage

@webbird
Copy link
Contributor

webbird commented Jun 23, 2014

Just the first step. ;)

@webbird
Copy link
Contributor

webbird commented Jun 23, 2014

Idea: To give the option to add the function to any module (old WB modules etc.), there could be an Admin Tool similar to Droplets that lets the admin add the code and/or import it from a repository provided by us. The Admin Tool would write the script and store the code into the DB, too.

In addition, we create a Open Graph interface (helper) that uses this scripts/code, but of course, other modules can use it, too.

Question: How to call the Open Graph interface? (PAGE_URL[?&]opengraph=1 or something?

@hertsch
Copy link
Contributor Author

hertsch commented Jun 23, 2014

The Open Graph Interface must be called before setting the page title, description and keywords because OG may change them. I think the best place is the template header and the OG Interface must check for modules which are active at the page and call them before they are delivering content. Modules like Bakery will also need all POST and GET parameters.

I'm handling OG (and headers) in two different ways:

  • the TemplateTools are looking at initializing for the active extensions/modules and setting page title, description, keywords,robots, canonical links and OG with the gathered information at template creation
  • the kitFramework retrieve the full rendered page from the CMS, process the kitFramework extensions, analyze the content, modify title, description, keywords, robots and canonical links and push the rendered page back to the CMS

I needed some time to get this working smooth and SEO like ... perhaps I should write this Interface for BC?

@webbird
Copy link
Contributor

webbird commented Jun 23, 2014

I would be happy if you did. :) I can implement the getfirst...-Script-Part and the Admin Tool and prepare the extensions repository.

Destination core version 1.1.

@webbird webbird added this to the vLater milestone Jun 23, 2014
@webbird webbird added the v1.1 label Jun 23, 2014
@webbird webbird modified the milestones: v1.1, vLater Jun 24, 2014
@hertsch
Copy link
Contributor Author

hertsch commented Jun 25, 2014

ok !

@webbird
Copy link
Contributor

webbird commented Oct 22, 2014

We will focus this in BC v1.2, where we are going to add more page options and allow enhanced template options. There already is an admin tool that allows to add getfirst* functions to old modules, but there's no need to install it at the moment, as the additional script will not be used.

I close this issue now, as we have the OpenGraph support on our roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants