Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Update Electron peer dependency to 1.8 #10

Closed
Rudloff opened this issue Feb 20, 2018 · 4 comments
Closed

Update Electron peer dependency to 1.8 #10

Rudloff opened this issue Feb 20, 2018 · 4 comments

Comments

@Rudloff
Copy link

Rudloff commented Feb 20, 2018

yarn check complains that electron-widevinecdm requires Electron 1.7:

error "electron-widevinecdm#electron@1.7.x" doesn't satisfy found match of "electron@1.8.2"

but it seems to work correctly with Electron 1.8.

Would it be possible to update peerDependencies to accept 1.8 as well?

@quanglam2807
Copy link
Owner

@Rudloff I'll try to update that soon. But actually, we would need a newer version of WidevineCDM. (Electron 1.7 uses Chrome 58, Electron 1.8 uses Chrome 59). Still, I can't find a good place to download extractable Chrome 59 setup file for Windows.

Currently, I'm using https://www.slimjet.com/chrome/google-chrome-old-version.php but the files only work with 7zip up to Chrome 58 :(

The old versions of Chrome before V58 are packed as 7zip self-extracting executable. Just run the executable and extract the files under any folder on your hard drive. Then launch Google chrome with chrome.exe under the extraction folder. After V59, the archived chrome old version files are official Chrome offline installers. Just uninstall any current version of Chrome first and then run the downloaded installer. It's a one-click installer without any interactive UI.

@quanglam2807
Copy link
Owner

I may drop win32 support. Certainly, the current binaries may work with Electron 1.8 but it's too risky. Considering this statement:

Note: The major version of Chrome browser has to be the same with the Chrome version used by Electron, otherwise the plugin will not work even though navigator.plugins would show it has been loaded. https://electronjs.org/docs/tutorial/using-widevine-cdm-plugin

@quanglam2807
Copy link
Owner

@Rudloff
Copy link
Author

Rudloff commented Feb 22, 2018

That was quick, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants