Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

feature: Apple Silicon support #1187

Closed
quanglam2807 opened this issue Nov 22, 2020 · 20 comments
Closed

feature: Apple Silicon support #1187

quanglam2807 opened this issue Nov 22, 2020 · 20 comments
Labels
enhancement New feature or request

Comments

@quanglam2807
Copy link
Member

Feature Request

Specifications:

  • App Version:
  • OS (macOS, Windows, Linux): macOS

If anyone has a Macbook with Apple M1 chip, please join this thread!

@quanglam2807 quanglam2807 added the enhancement New feature or request label Nov 22, 2020
@scottrbaxter
Copy link
Contributor

scottrbaxter commented Nov 24, 2020

MacBook Air (M1, 2020) on hand... there are plenty of developer tools that i'm currently testing as well, would be happy to help out with Webcatalog if/when needed.

@williamli
Copy link

👋🏽

@williamli
Copy link

@quanglam2807 i am happy to help test M1 support. I see that you have switched over to electron v11.

@quanglam2807 quanglam2807 pinned this issue Dec 1, 2020
@quanglam2807
Copy link
Member Author

Thank you, guys! This is currently blocked by this: electron-userland/electron-builder#5426

@quanglam2807
Copy link
Member Author

first build: https://github.com/webcatalog/webcatalog-app/releases/download/v27.2.0-alpha/WebCatalog-27.2.0-alpha-arm64.dmg

@scottrbaxter
Copy link
Contributor

@quanglam2807 I've installed the this initial alpha build, and was able to install a custom app with the Brave (which is currently Intel still) engine. So far it seems to be running fine, though I've only just started testing.

I then tested a custom app using the WebCatalog Engine, and also the Github app from the Discover page using this same engine, and it crashes with Failed to install <app_name>. DISMISS

Screen Shot 2020-12-14 at 9 22 47 PM

Are there any specific logs that'll help you out?

@quanglam2807
Copy link
Member Author

Thank you, @scottrbaxter! My bad, I forgot to push the files for WebCatalog Engine. Can you try again, please? Normally, bugs like this are reported automatically by the app so you don't need to do anything.

@quanglam2807
Copy link
Member Author

For testing, with the alpha build, WebCatalog apps, WebCatalog-Engine-based apps and WebKit-based should run natively on M1 Macbook

@scottrbaxter
Copy link
Contributor

That did it, thanks!

@quanglam2807
Copy link
Member Author

That did it, thanks!

Does it mean it works?

@scottrbaxter
Copy link
Contributor

Yes, the WebCatalog Engine is working so far. Started basic testing, but so far it's working.

Is there anything specific that you'd like me to test?

@quanglam2807
Copy link
Member Author

Not really, if the generated apps are ARM64-based then everything is working properly. :) Thank you so much, @scottrbaxter

@quanglam2807
Copy link
Member Author

I'll release an update to the WebCatalog app shortly so we can test if the updater is working correctly with M1 version. If it works, then I think everything is ready :)

@quanglam2807
Copy link
Member Author

New build (27.2.0-rc) is up. Please try to update to the new version using the app updater to see if it works correctly.

@scottrbaxter
Copy link
Contributor

I was able to update to 27.2.0-rc, and the app runs fine. That said, I happened to notice that the 27.2.0-alpha version I manually downloaded from your link (above), when I Get Info on the /Applications/WebCatalog.app, I saw Application (Apple Silicon), however, now that the app auto-updated to 27.2.0-rc, Get Info states Application (Intel), just as the stable version prior to this alpha release.

I'm not sure what exactly needs to be done during updates to keep it as Apple Silicon, but I'm happy to test if you can determine why it would have reverted to Rosetta2/Intel.

Screen Shot 2020-12-16 at 12 52 45 AM

Screen Shot 2020-12-16 at 12 52 06 AM

@quanglam2807
Copy link
Member Author

Thank you for reporting, @scottrbaxter. It seems like it happens because 27.2.0-alpha is running an outdated version of the updater. Can you manually download and install the Apple Silicon version for 27.2.0-rc: https://github.com/webcatalog/webcatalog-app/releases/download/v27.2.0-rc/WebCatalog-27.2.0-rc-arm64.dmg and wait for the next update to see if the bug occurs again?

@scottrbaxter
Copy link
Contributor

Done.

Screen Shot 2020-12-16 at 2 38 20 AM

@quanglam2807
Copy link
Member Author

Awesome! v27.2.0 is up :)

@videopilot
Copy link

Amazing!

But on my new M1 Mac, it seems the auto-generated icon tiles are bigger than the big sur style.

@quanglam2807
Copy link
Member Author

Amazing!

But on my new M1 Mac, it seems the auto-generated icon tiles are bigger than the big sur style.

Can you email me at quang.lam@webcatalog.app some examples? The icon template comes straight from Apple so I'm quite certain the size is correct.

@quanglam2807 quanglam2807 unpinned this issue Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants