Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ability to work with customized built-ins #376

Open
franktopel opened this issue Dec 19, 2018 · 6 comments
Open

Add tests for ability to work with customized built-ins #376

franktopel opened this issue Dec 19, 2018 · 6 comments
Labels
Additional Tests For issues that identify good additional tests to run on all libraries

Comments

@franktopel
Copy link

franktopel commented Dec 19, 2018

Check if frameworks are able to recognize the special meaning of the is=""-attribute, and that it cannot be handled like a traditional attribute when it comes to dynamic element creation.

@robdodson
Copy link
Contributor

@franktopel hm that's interesting.

I guess a strawman proposal would be to create an element like <a is="x-link"> and verifying that it has both the properties associated with a regular link, as well as any properties added by the type extension.

@jonyc
Copy link

jonyc commented May 21, 2019

It seems Angular still does not handle the is="" attribute correctly when rendering: angular/angular#6827 (comment).

Maybe the test could include something like comparing the innerText of the extended button in the following demos:
Angular (not working): https://stackblitz.com/edit/angular-dginkc
React (working): https://stackblitz.com/edit/react-saktyo

@MichaelBrimer
Copy link

And it is still not working in Angular, I have tested https://stackblitz.com/edit/angular-dginkc
with Angular version 8.2.14 and Angular version 9.0.0-rc.7. It would be nice to have test for this and it would also be more fair for React, since at the moment the first impression is that it a100% works in Angular but not in React. Btw I work in Angular.

@robdodson
Copy link
Contributor

I think this would be a tricky test to add because the is="" attribute is not and likely will never be supported in Safari.

@Kim-Andersen
Copy link

@rob

I think this would be a tricky test to add because the is="" attribute is not and likely will never be supported in Safari.

What makes you think Safari likely will never support this?

Also, does that mean that you only consider scenarios that are well supported by all major browsers?

@robdodson
Copy link
Contributor

What makes you think Safari likely will never support this?

This comment from Safari is the best explanation I could find:
WICG/webcomponents#509 (comment)

Also, does that mean that you only consider scenarios that are well supported by all major browsers?

Yeah I think so. I feel weird asking a framework to do work to support a feature which another browser actively opposes.

I think if all the browsers agreed to a feature, but just hadn't gotten around to implementing it yet, that would be a different scenario and it would make sense to have tests then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional Tests For issues that identify good additional tests to run on all libraries
Projects
None yet
Development

No branches or pull requests

6 participants