Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

FireFox 51 (curet) fails Custom Elements: Element#attachShadow was not patched. #63

Closed
puppetmaster3 opened this issue Feb 16, 2017 · 4 comments

Comments

@puppetmaster3
Copy link

I get Custom Elements: Element#attachShadow was not patched error.

Works fine on Chrome.
https://www.masons-foundation.org/home/feed/

FireFox 51 and poly v 1.04a - both latest.

@puppetmaster3
Copy link
Author

More info:

But https://www.masons-foundation.org/home/feed/ in FF makes error:
Custom Elements: Element#attachShadow was not patched.

@puppetmaster3 puppetmaster3 changed the title Firebase 51 (curret) fails Custom Elements: Element#attachShadow was not patched. FireFox 51 (curet) fails Custom Elements: Element#attachShadow was not patched. Feb 16, 2017
@bicknellr
Copy link
Contributor

bicknellr commented Feb 17, 2017

Oh, this is just telling you that Element.prototype.attachShadow doesn't exist (you're running in a situation without Shadow DOM) and that it didn't patch the (non-existent) function. Maybe I should have used console.info instead of console.warn for these. You shouldn't need to worry about this if you aren't using Shadow DOM.

@bicknellr
Copy link
Contributor

bicknellr commented Feb 17, 2017

If you're using a Shadow DOM polyfill (like Shady DOM) and you're still seeing this error, you need to load the Shadow DOM polyfill first so that it can do its patching before the custom elements polyfill does its own.

edit: Additionally, the custom elements polyfill needs to use the Shadow DOM polyfill's methods to inspect / walk the tree. If it doesn't, the custom element polyfill will be operating on the 'composed' tree and callbacks can end up being called on the wrong elements and at the wrong times.

@bicknellr
Copy link
Contributor

@puppetmaster3, I'm going to close this since I don't think this is actually a bug. If you find that this still happens in situations where you're using Shadow DOM, please leave a comment and I'll reopen it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants