Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Version 2.1.1 master doesn't compile #995

Closed
steelraiden opened this issue Sep 4, 2018 · 17 comments
Closed

Version 2.1.1 master doesn't compile #995

steelraiden opened this issue Sep 4, 2018 · 17 comments

Comments

@steelraiden
Copy link

  • I cloned the git repository
  • I have node.js (last version)
  • ran npm install -g gulp
  • I have java installed (last version)
  • ran npm install
  • ran npm run build

Error:

gulp
[00:27:27] Using gulpfile ~\Desktop\webcomponentsjs-master\gulpfile.js
[00:27:27] Starting 'closure'...
[00:27:27] Starting 'clean'...
[00:27:27] Finished 'clean' after 21 ms
[00:27:27] Starting 'closurify-ce'...

events.js:183
throw er; // Unhandled 'error' event
^
Error: Compilation error: Unhandled flag: outputWrapperFile
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @webcomponents/webcomponentsjs@2.1.1 build: gulp
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @webcomponents/webcomponentsjs@2.1.1 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

@TimvdLippe
Copy link
Contributor

I don't seem to have a problem when building. Are you sure you have Java installed? If so, which version of Java are you running?

@TimvdLippe
Copy link
Contributor

Closing per above comment. Feel free to reopen if you are still encountering issues.

@AaronNGray
Copy link

AaronNGray commented Sep 20, 2018

Does not build on Windows with Java jdk-10.0.2_windows-x64_bin.exe
Getting same error as @steelraiden.

java is on the command line but NOT javac dunno if that is relevant or not ?

@AaronNGray
Copy link

Also cdnjs.cloudflare.com does not have the bundle files for https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.0.2/webcomponents-loader.js

@TimvdLippe
Copy link
Contributor

This might actually be related to Polymer/tools#405 Could you try with Java 8 and see if that fixes the issue?

@TimvdLippe TimvdLippe reopened this Sep 20, 2018
@AaronNGray
Copy link

AaronNGray commented Sep 20, 2018

getting the same result.

@AaronNGray
Copy link

@TimvdLippe what platform are you using please ?

@TimvdLippe
Copy link
Contributor

I am running Java 8 and Node 10. I am also using gulp 4, that might be it? Do make sure you are using the locally installed gulp from this repo, rather than the globally installed gulp, as that is still stuck on 3.

@AaronNGray
Copy link

@TimvdLippe Are you on Windows or Linux or Mac OSX ?

@AaronNGray
Copy link

Gulp v3 will try v4

@AaronNGray
Copy link

AaronNGray commented Sep 20, 2018

package.json has "gulp": "^3.8.8", And that's still giving :-

 Error: Compilation error: Unhandled flag: outputWrapperFile

@TimvdLippe
Copy link
Contributor

Are you on Windows or Linux or Mac OSX ?

I am on Linux, but others are on OSX. Don't think we have Windows developers on the team atm.

package.json has "gulp": "^3.8.8",

Hm, you are correct. I thought I had updated that package to 4 🤔 That might be the issue though.

@AaronNGray
Copy link

AaronNGray commented Sep 20, 2018

npm install gulp --save-dev gives "gulp": "^3.9.1", still gives bug

@AaronNGray
Copy link

gulp 4.0.0 gives :-

@webcomponents/webcomponentsjs@2.1.3 build C:\Users\aaron\GitHub\webcomponentsjs
gulp

assert.js:337
    throw err;
    ^

AssertionError [ERR_ASSERTION]: Task function must be specified
    at Gulp.set [as _setTask] (C:\Users\aaron\GitHub\webcomponentsjs\node_modules\undertaker\lib\set-task.js:10:3)
    at Gulp.task (C:\Users\aaron\GitHub\webcomponentsjs\node_modules\undertaker\lib\task.js:13:8)
    at Object.<anonymous> (C:\Users\aaron\GitHub\webcomponentsjs\gulpfile.js:171:6)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)

@AaronNGray
Copy link

AaronNGray commented Sep 20, 2018

moving over to try on Debian as I need this working … so often Winblows gets left behind on node.js based projects ! Looks like Windblows has been taken to the undertaker :-

at Gulp.set [as _setTask] (C:\Users\aaron\GitHub\webcomponentsjs\node_modules\undertaker\lib\set-task.js:10:3)

@AaronNGray
Copy link

cool building on Linux ! Dunno if I have the time or the knowledge of the packages to look into it on Windows though. But will run tests on request :)

@TimvdLippe
Copy link
Contributor

We currently do not support building the polyfills on Windows right now and I doubt we will in the future. The team develops on Unix systems for building the polyfills. If you are a user of the polyfills, you can use the generated output from NPM, which should work in Windows browser environments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants