Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if one page and no pager #443

Closed
Nuranto opened this issue Jan 22, 2020 · 2 comments · Fixed by #445
Closed

Error if one page and no pager #443

Nuranto opened this issue Jan 22, 2020 · 2 comments · Fixed by #445
Labels
bug
Milestone
v3.0.0-beta.6

Comments

@Nuranto
Copy link

Nuranto commented Jan 22, 2020 •
edited

Uncaught Error: Element ".pages ol" not found for "pagination.element"

If there is one page only, some framework may not show at all the pages links. That case should be errorless. (even if we will agree, the best would be to instantiate IAS only if there is more than one page)
@Nuranto Nuranto added the bug label Jan 22, 2020
@fieg
Copy link
Member

fieg commented Jan 22, 2020

Yes, I think it might be better to throw a warning instead of an Error.

@fieg fieg added this to the v3.0.0-beta.6 milestone Jan 27, 2020
@fieg fieg mentioned this issue Jan 27, 2020
Merged
@fieg fieg closed this as completed in #445 Jan 29, 2020
@fieg
Copy link
Member

fieg commented Feb 10, 2020 •
edited

This landed in v3.0.0-beta.6 which was released earlier today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.0.0-beta.6
2 participants
@fieg @Nuranto