Use Default trait for default values #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for late, I checked it in near time. It's my first project on rust, i many things rewrite today if i had time 😃 |
|
@upsuper lots of crates have new and a default method. Could you keep the new method un-deprecated while providing |
|
@DarrienG done |
|
@webdesus this should be good to go now 🤙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Defaulttrait for default values is probably more idiomatic for Rust. In this case, it has a benefit that if a user doesn't need to change anything from the default value, they can simply doDefault::default()rather than having to reference theCopyOptionstypes.