Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: The 'drawerOpen' prop is an antipattern. #78

Closed
abrie opened this issue Jan 30, 2020 · 1 comment
Closed

Refactor: The 'drawerOpen' prop is an antipattern. #78

abrie opened this issue Jan 30, 2020 · 1 comment

Comments

@abrie
Copy link
Member

abrie commented Jan 30, 2020

The app has two render states; NavDrawer Open, and NavDrawer Closed. The state is communicated to components via a prop. Ideally this should be moved to a a context and have better inversion of control.

image

@DanielJWagener
Copy link
Collaborator

Would fixing this issue also fix all the components re-rendering every time the drawer opens or closes? I was playing around with the app just now, and the projects table's re-rendering is kinda glaring. I couldn't figure out how to fix it though-- that problem is defying my understanding of how hooks work.

@abrie abrie closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants