Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP_PROXY #86

Closed
openscript opened this issue Oct 25, 2023 · 3 comments
Closed

Support HTTP_PROXY #86

openscript opened this issue Oct 25, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@openscript
Copy link
Contributor

openscript commented Oct 25, 2023

Unfortunately I need to run the tests in an environment, where I can only access the internet through a proxy. wdio-vscode-service uses undici for it's requests. undici doesn't support the most common way to define proxies: nodejs/undici#1650

It doesn't look like undici will support this any time soon. Native fetch is slowly arriving, but types are not included for Node 18. node-fetch would work, as it supports HttpAgents.

Is there another workaround I haven't thought of?

https://github.com/webdriverio-community/wdio-vscode-service/blob/17522803666322102a9a082512792dd030d667dc/src/launcher.ts#L8C26-L8C32

@christian-bromann
Copy link
Contributor

Thanks for reporting!

Switching to node-fetch makes sense since we will switch to native fetch in WebdriverIO with the next upgrade and this would make this transition easier.

We greatly appreciate any contributions that help resolve the bug. While we understand that active contributors have their own priorities, we kindly request your assistance if you rely on this bug being fixed. We encourage you to take a look at our contribution guidelines or join our friendly Discord development server, where you can ask any questions you may have. Thank you for your support, and cheers!

@christian-bromann christian-bromann added the help wanted Extra attention is needed label Oct 25, 2023
@openscript
Copy link
Contributor Author

openscript commented Oct 26, 2023

I decided against switching to node-fetch as the API of undici should be on par and I think moving to native fetch should be easy.

@christian-bromann
Copy link
Contributor

Thanks for raising a PR. It is merged and will be released next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants