Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wedriverio bin path issue #27

Merged

Conversation

aliokan
Copy link
Contributor

@aliokan aliokan commented Oct 15, 2015

fix #20 wedriverio bin path issue due to flattening dependency, based on npm/npm#9718 (comment) solution.

!!! only tested on npm 2.14.2 and node v4.0.0 on MacOS 10.9.5

fix wedriverio bin path issue due to flattening dependency, based on npm/npm#9718 (comment) solution. 

!!! only tested on npm 2.14.2 and node v4.0.0 on MacOS 10.9.5
@benweizhu
Copy link

When will they fix this issue?

christian-bromann added a commit that referenced this pull request Nov 16, 2015
fix wedriverio bin path issue
@christian-bromann christian-bromann merged commit 9fa76d2 into webdriverio-boneyard:master Nov 16, 2015
@kresli
Copy link

kresli commented Nov 23, 2015

This is not working on node 5.0.0 npm 3.3.7
Removing __dirname from wdioBin = path.join(__dirname, 'node_modules', '.bin', isWin ? 'wdio.cmd' : 'wdio'); fix this at least on 3.3.7 version

@aliokan
Copy link
Contributor Author

aliokan commented Nov 23, 2015

It's work with node v5.0.0 and npm 3.3.6
In this patch __dirname is removed :

-            wdioBin = path.join(__dirname, 'node_modules', '.bin', isWin ? 'wdio.cmd' : 'wdio');
+            wdioBin = require.resolve(path.join('webdriverio', 'bin', isWin ? 'wdio.cmd' : 'wdio'));

@kresli
Copy link

kresli commented Nov 24, 2015

Sorry, you are right. But either this is merged with master I still see the old index.js content. I triple check the gulp-webdriver version in my project and its on 1.0.1 ( installed by npm install gulp-webdriver@1.0.1 ). Not sure if this is an issue with npm :/
If I clone this repo, everything is up to date.
If I try to install it with npm, I have old version of index.js

@aliokan
Copy link
Contributor Author

aliokan commented Nov 24, 2015

Look the branch Master commits history : https://github.com/webdriverio/gulp-webdriver/commits/master
My patch is applied after the v1.0.1 release.
If you want to install a commit not already released, you can specify directly a commit needed, for example :
npm install https://github.com/webdriverio/gulp-webdriver.git#9fa76d2c2035c2db28944c11b2c0be6991a1c931

@kresli
Copy link

kresli commented Nov 24, 2015

Thanks. Works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Haven't found the WebdriverIO test runner
4 participants