Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I add support for Protractor? #33

Closed
jan-molak opened this issue Jul 12, 2020 · 5 comments
Closed

Should I add support for Protractor? #33

jan-molak opened this issue Jul 12, 2020 · 5 comments

Comments

@jan-molak
Copy link
Contributor

Hi @Georgegriff and thanks for your amazing query-selector-shadow-dom!

I understand that your motivation behind writing this library was to provide support for Playwright, which now has its own CSS selector engine inspired by your work. In light of this, are you planning to continue to maintain this library?

If the answer is yes, would you be open to me submitting a PR adding support for Angular Protractor?

Thanks,
Jan

@Georgegriff
Copy link
Contributor

This library existed before playwright, it's just playwright was the easiest to integrate with recently (until it wasn't needed anymore) But of course, more than happy! Although bare in mind have have zero experience with that test framework. So any examples/background or test cases would be great.

It may also be simpler to derive a new library with this is a dependency, up to you

@jan-molak
Copy link
Contributor Author

Hi @Georgegriff! Many thanks for merging the PR 👍
Is there anything left to do before we could have the new feature available on NPM?

@Georgegriff
Copy link
Contributor

I'll try to release it today when I get chance

@Georgegriff
Copy link
Contributor

Released in 0.6.0

@jan-molak
Copy link
Contributor Author

Brilliant, thanks @Georgegriff :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants