This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Improve document height measurement #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take it! Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the website I was testing, due to the layout method we use (absolute positioning), the document height was always coming in as 0 in Chrome (would work fine in FF though). When Graphicsmagick attempted to use the screenshot, it would complain that one of the dimensions was zero. To fix this, I did a little bit of research (aka searched Stack Overflow) and found a solution, which in my testing fixes the issue.
I've run the WebdriverCSS tests locally and it works great. I did my testing against the
beta-rc1branch though, in order to test in WebdriverIO >3. I'm not sure if I should merge in to the master branch orbeta-rc1.FYI, this is the page I'm having issues with. If you inspect the html/body tags in chrome, you'll notice the height of those elements is 0 (due to the
.overlaycontent being absolutely positioned).