Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkK findings #551

Open
2 tasks done
musicEnfanthen opened this issue Aug 16, 2022 · 13 comments
Open
2 tasks done

TkK findings #551

musicEnfanthen opened this issue Aug 16, 2022 · 13 comments

Comments

@musicEnfanthen
Copy link
Member

musicEnfanthen commented Aug 16, 2022

  • M 317 Sk2.1: #path242 needs group element
  • M 317 Sk2.1.2: m3, s2, 2/8: Red eighth flag in SVG
@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Feb 14, 2023

M317

  • M 317 Sk4 T. 3B-6:
    • doubled svgGroupId "g10030" for m. 6, sys. 3-4, and m. 6, sys. 4 ("fis1 durch Einkreisung getilgt"), probably wrong in second case
  • M 317 Sk4 T. 7-12:
    • Missing tkk entry for tkk-group m. 12, sys. 8: [xx] ? Or too many classes? (order of svg elements)
  • M 317 Sk4 T. 13-15:
    • Missing tkk entry for tkk-group m. 13, sys. 15,16: rests ? Or too many classes? (order of svg elements)
    • Missing tkk entry for tkk-group m. 14, sys. 16: [xx] ? Or too many classes? (order of svg elements)
  • M317 Sk3.1.3:
    • Linkbox grouping for all link boxes missing?
    • In SVGs, this sketch includes system 5 (because of the "Strich mit unklarer Bedeutung."). Sys, 5 not declared in SourceDescription.
  • M317 Sk3.1:
    • Nested tkk groups g1225 in g1241 works, but will not be rendered properly
    • Linkbox grouping for Sk1 missing
    • Link to C:Sk1 not correct (in comment for m. {5}, sys. 4, 6/8)
  • M317 Sk3.1.2:
    • Linkbox grouping for Sk1 missing
  • M317 Sk1:
    • Linkbox grouping for Sk2.1.3 missing

@masthom
Copy link
Contributor

masthom commented Feb 28, 2023

M 317 Sk 4, Missing tkk entry for tkk-group m. 14, sys. 16:
##looks fine to me. what is wrong?

M317 Sk3.1, Link to C:Sk1 not correct (in comment for m. {5}, sys. 4, 6/8):
##looks fine to me, what is wrong?

M317 Sk3.1.3, Linkbox grouping for all link boxes missing?:
##big mystery... grouping exists, sth is wrong anyway.

for the other findings in M317 see PR #852

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Feb 28, 2023

M 317 Sk 4, Missing tkk entry for tkk-group m. 14, sys. 16:
##looks fine to me. what is wrong?

The SVG viewer displays a tkk-box for "u. von u. 3 sowie Winkel mit rotem Buntstift." which is correct, but another (smaller) tkk-box inside it around the "u. 3". But there is no separate tkk for that location. So wether the tkk comment is missing or there is an additional misplaced tkk-class in the SVG file.

M317 Sk3.1, Link to C:Sk1 not correct (in comment for m. {5}, sys. 4, 6/8):
##looks fine to me, what is wrong?

Yes, seems to be fine for me, too. Probably there was some issue before the latest release, but it seems to be gone.

@masthom
Copy link
Contributor

masthom commented Feb 28, 2023

I see. M 317 Sk4 should be fixed now (update PR #852).

@masthom
Copy link
Contributor

masthom commented Mar 1, 2023

M317 Sk3.1.3, Linkbox grouping for all link boxes missing?:
##big mystery... grouping exists, sth is wrong anyway.

just a guess: this is the only item so far with linkbox grouping + "rowtable": true, might this cause the issue?

@musicEnfanthen
Copy link
Member Author

I don't think so. But I recognized that in other files there is a group with an aria-label for the linkBox label within the g.link-box , something like:

<g
       aria-label="Sk2.1"
       id="text110"
       style="font-weight: 700; font-size: 12px; font-family: Arial-BoldMT, Arial;  isolation: isolate;  fill: #7d7d7d;"
       class="cls-13"> ...

This is missing for all link-boxes in Sk3.1.3

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Mar 2, 2023

M30 & M34

  • M 34 Sk 1

    • Missing svgGroupId (and class in svg?) for m. 1, sys. 2, 3/4: Viertelnote gestrichen
  • M 30 Sk1

    • T. {9D-12B}

      • m. {9D-12B} in SVG vs. m. {9D–10D, 11B}, 12B in sourceDesc
    • T. 7B -{10C}:

      • Des (?) in: {
        "svgGroupId": "g1156",
        "measure": "9C",
        "system": "11",
        "position": "1. Note",
        "comment": "des gestrichen."
        },
    • T. 9E-{15B}

      • {13B–15B} (?) in: {
        "svgGroupId": "g1197",
        "measure": "{13B–14B}",
        "system": "14–15",
        "position": "",
        "comment": "Takte pauschal gestrichen."
        },
    • T. 17–21

      • [b]b2 ... [a]g2 (?) in: {
        "svgGroupId": "g1131",
        "measure": "19",
        "system": "1",
        "position": "6/8",
        "comment": "b2 überschreibt g2."
        },
    • T. 25–29B

      • [a]a1 ... [b]ges1(?) in: {
        "svgGroupId": "g1108",
        "measure": "27",
        "system": "7",
        "position": "4. Note",
        "comment": "a1 überschreibt ges1."
        },
      • class and groupId in SVG missing for {
        "svgGroupId": "g37",
        "measure": "{28A–29A}",
        "system": "7",
        "position": "",
        "comment": "Noten pauschal gestrichen."
        },

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Apr 2, 2023

M212 TF 1

  • p. 1

    • The first tkk in m.1 has as location: (2/8) bis Taktende for the hairpin, but the crescendo hairpin ends at 2/4 ?
  • p. 2

    • The tkk for m. 14, 1/8, and (now) m. 14 1/8 (but probably m. 23, see below) dispaly accidentals in brackets. Correct? //TA: correct!
    • There is no tkk displayed on the very last asterisk m. 23, but a second tkk displayed in m. 14, lower piano, that reads: 14 | Klav. | 1/8 | (♯) zu Gis1/Cis und (♮) zu H/g als redundant weggelassen. B: Akkoladenwechsel nach T. 22. which is probably the missing tkk for m. 23?
  • SourceDescription:

    • Description mixes Flecke and Flecken for plural forms.
    • FirmSign mentioned, but no image/type included?
    • Die Korrekturen in <strong>B</strong>B betreffen Textfassung 2. Probably without the repeated B ? (ping @masthom since added after your PR)
    • Wouldn't add a line break in the title description

line breaks also in op. 25 source A (Taktzahlen, Instrumentenvorsatz)!?
for the other points see #910

  • Tkk class and group id missing for
                   "svgGroupId": "",
                   "measure": "18",
                   "system": "Ges.",
                   "position": "1. Note",
                   "comment": "Text sic: (Ver-)storb(-nen) ohne Binnen-Apostroph. Rosegger_PM: Verstorb’nen."
               },

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Apr 3, 2023

Op. 22 SkRT

  • SourceDescription:

    • Writing Material mentions 3 types of sheets, but refers only to "Bl. 1" and "Bl. 2"
    • Also: correct that the "shortest" sheet type has 9 systems, and the longer ones have only 8 systems?
  • SkRTc

    • Last tkk on row variant 47 had: Bl. 3r | 8a | Ub. Corrected to Ud according to SourceDescription and transcription, correct?

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Apr 14, 2023

Op. 27 SkRT

  • SkRTa:

    • Row form Ges should be Kgis (?) in
      Bl. 1r | 1b | Ges: 10.–11. Reihenton | Auf Rasur: vermutlich ♭b1–♮h1 geändert zu ♭b–♮h.
  • SkRTb:

    • Tkk for second dividing line is missing (but duplicates svg id and content of that in SkRTa = C&P error?):
      Bl. 2r | 1b–8b | K- und KU-Formen: 6.–7. Reihenton | Strich zur Gliederung der Hexachorde mit rotem Buntstift. Vermutlich nachträglich gezogen, da der Strich mit einzelnen Notenköpfen kollidiert.
    • Kd should be Ka (?) in
      Bl. 2r | 1b | Kd | Reihennummerierung 18 mit grünem Buntstift.

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Jan 10, 2024

@chael-mi

M 37 Sk1

  • SVG:

    • missing link-box class for linkBox to Sk1
  • SourceDescription:

    • missing files for firmSign for sources A and B
    • correct order of sketches in sourceDescription?
    • wrong measure numbers for Sk2 and Sk3?

M 30 Sk1 (11/11)

  • wrong measure numbers in link box labels (1-5 and 6-9 should be 1-4 and 5-9)

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Feb 8, 2024

@chael-mi

M 35/42

  • SVGs for Sk1.1 and Sk2 missing

  • TF1:

    • T. 14 = 23?
    • 1. Note = 1/4?
  • Sk1b:

    • TkK for deleted D in m. {9A} missing
  • Sk1d:

    • 16 = 16B?
    • TkK for deleted notes in m. {17B} missing
    • TkK for deletion m. 18 missing
    • supplied accid classes missing in some cases
    • linkbox to sk1 t.10-15 correct?
  • Sk1e:

    • 22 = {22}?
  • Sk2

    • Supplied clef (and key?) missing
  • SourceDescription:

    • missing files for firmSign for sources B and D (m34 reused for A and C)

@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented Apr 2, 2024

@chael-mi

M 22

  • Sk1:

    • m. 2, sys. 23: Fehlender Akkordhals?
    • m. 7, sys. 22, 1.-2. Note, commentary: "Oberstimmenschicht: " ?
  • Sk2:

    • m .5, sys. 27, 3/4, commentary: "Viertelnote" tilgen?
  • Sk3:

    • m. 3, sys. 26, 5/8, commentary: h1/d2 überschreibt a1/c2 [Viertelnote in Notentext ?]
    • m. 4, sys. 26, 2-3/16: Pause ergänzen?
    • m. 5B, sys. 26, 3/8: h2/h1 überschreibt a2?
    • m. 6, sys. 26, 2/4, commentary: "Unterstimmenschicht: " ?
    • m. 7, sys. 24: (5/8) statt 5/8 ?
  • Sk4:

    • m. 8, sys. 19, 7/16: Überschreibung?
  • Sk5: ----

  • Sk6:

    • m. 4, sys. 15: Ergänzung # zu h? oder g (=[#]gis) gemeint?
    • m. 7, sys. 16, 4/8: Überschriebenes d2 = Achtelnote?
  • Sk7: ----

  • Sk8:

    • Darstellung von LinkBox zu Sk9 korrekt? Öffnung nach unten?
  • Sk9:

    • m. {1A-2A}, commentary: "Takte"?
  • Sk10: ---

  • Sk11:

    • m. 6, sys. 5, 6/8, commentary: "Oberstimmenschicht:"?
  • Sk12:

    • m. 3, sys. 3, 5–6/8: "(5–6/8)" or "5.–7. Note"?
  • Sk13-16: ---

  • Sk17:

    • m. 1, sys. 14, 4/16: A/a überschreibt c/c1. [= 3/8?]
    • m. 5, sys. 14, 1.–2. Note., commentary: E–e/e überschreibt Gis1/Gis–Gis/gis. [= "E–E/e überschreibt #Gis1/#Gis–Gis/gis." ?]
  • Sk18:

    • m. 2, sys. 16, 16 [= "1. Note"?]
    • m. 7, sys. 13, 2.–3. Note [= "[2.-3. Note]"? ], commentary: a–f1 überschreibt d2–a1. [= "a1–f1 überschreibt d2–a1."?]
  • Sk19: ---

  • Sk20:

    • Schlüssel und Vorzeichnung zusammen klammern?
  • Sk21:

    • m. {1A} | 17–18 | (1/4) | Noten gestrichen. [= "{1A} | | | Takt pauschal gestrichen."?]
    • m. 2, sys. 18, 1–2/8: E–g überschreibt Gis–h. [= E-[#]gis?]
    • m. 2, sys. 18, 5/8: gis überschreibt h. [kein ergänztes Akzidenz im Notentext?]
    • Vgl. auch Anmerkung m. 3
  • Sk22: ---

  • Sk23:

    • 1/1: Linkbox zu Sk23.1 = Sk23 T. 7?
    • m. 1, sys. 3, Taktanfang: Bassschlüssel überschreibt Violinschlüssel?
    • m. 7, sys. 4: Ort im Takt bei beiden Tkk uneindeutig? 1/4 = (1/4)?; 2/8 = (3/8)?
  • Sk24:

    • m. 7, sys. 1, 2. Note, commentary: "E/gis/h/e1" [= e/gis/h/e1?]; "sic. lies: ..." [= sic; lies: ...?]
  • Sk25:

    • 2/2: Darstellung von LinkBox zu Sk26 T. 5 korrekt? Besser "Sk26 T. 1–5"? Öffnung nach unten?
  • Sk26:

    • m. 1, sys. 8, 5/8: h überschreibt c2. [= h1?]
    • m. 8, sys. 11, 6–7/8 [= 6–7/16?]
    • 2/2: Darstellung von LinkBox zu Sk27 T. 4–6 korrekt? Besser "Sk27"? Öffnung nach unten?
  • Sk27/Sk27.1: ---

  • Sk28

    • m. {2A}: Oberstimmenschicht: Ort im Takt: "1. Note" korrekt?
    • m. 5, sys. 14, 1. Pause: Punktierte Achtelnote [= Punktierte Achtelpause?]
    • m. 7, sys. 9, (2/4): c1/a überschreibt a/e. [= "c1-a überschreibt a-e" ?]
  • Sk29:

    • m. 8, sys. 2, 1–3/4: Noten gestrichen. -> alle?
  • Sk30: ---

  • Sk31:

    • SVG Titel: "T. 8" fehlt
    • 2/2: "M 22" von LinkBox zu Sk28.1 tilgen
  • Sk32: ---

  • Sk32.1:

    • SVG: 8A [= {8A}?]
    • "M 22" von LinkBox zu Sk32.1.1 tilgen
  • Sk32.1.1:

    • SVG, header: 32.1 = 32.1.1 ?
  • Sk33:

    • m. 5 bis 6, sys. 14, letzte Note 1. Note: "Unterstimmenschicht: f1 überschreibt g1 in T. 6; Ligatur zu g1 in T. gestrichen." [= in T. 6?]
    • m. 6, sys. 14, 3/4: Mittelstimmenschicht: f2 überschreibt h1. [= [a]h1?]
    • m. 8, sys. 14, 3/4: Oberstimmenschicht [=Mittelstimmenschicht?]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants