Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some installs pick up spark-js-sdk--test-users #20

Closed
ianwremmel opened this issue Aug 5, 2016 · 0 comments
Closed

Some installs pick up spark-js-sdk--test-users #20

ianwremmel opened this issue Aug 5, 2016 · 0 comments
Labels
bug-fix PRs that fix bugs

Comments

@ianwremmel
Copy link
Contributor

Change it to an optional dependency
@ianwremmel ianwremmel added the bug-fix PRs that fix bugs label Aug 5, 2016
@ianwremmel ianwremmel mentioned this issue Aug 5, 2016
Closed
4 tasks
@ianwremmel ianwremmel changed the title Some install pick up spark-js-sdk--test-users Some installs pick up spark-js-sdk--test-users Aug 5, 2016
ianwremmel referenced this issue in ianwremmel/spark-js-sdk Aug 7, 2016
@ianwremmel
test(spark-core): use test users helper instead of spark-js-sdk--test…
83dbd78 
…-users

Also, make spark-js-sdk--test-users an optional dependency to ease third-party installs

Fixes #20
ianwremmel referenced this issue in ianwremmel/spark-js-sdk Aug 8, 2016
@ianwremmel
test(spark-core): use test users helper instead of spark-js-sdk--test…
41b0991 
…-users

Also, make spark-js-sdk--test-users an optional dependency to ease third-party installs

Fixes #20
ianwremmel referenced this issue in ianwremmel/spark-js-sdk Aug 12, 2016
@ianwremmel
test(spark-core): use test users helper instead of spark-js-sdk--test…
e2c0d65 
…-users

Also, make spark-js-sdk--test-users an optional dependency to ease third-party installs

Fixes #20
ianwremmel referenced this issue in ianwremmel/spark-js-sdk Aug 21, 2016
@ianwremmel
test(spark-core): use test users helper instead of spark-js-sdk--test…
ef76b96 
…-users

Also, make spark-js-sdk--test-users an optional dependency to ease third-party installs

Fixes #20
ianwremmel referenced this issue in ianwremmel/spark-js-sdk Aug 24, 2016
@ianwremmel
test(spark-core): use test users helper instead of spark-js-sdk--test…
5a3d88f 
…-users

Also, make spark-js-sdk--test-users an optional dependency to ease third-party installs

Fixes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-fix PRs that fix bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianwremmel