fix: dispose effects on call to LocalStream.stop #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
approved these changes
Apr 16, 2024
bbaldino
pushed a commit
that referenced
this pull request
Apr 16, 2024
## [2.6.1](v2.6.0...v2.6.1) (2024-04-16) ### Bug Fixes * dispose effects on call to LocalStream.stop ([#75](#75)) ([60205bc](60205bc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply disposes any effects added to the
LocalStreamwhenLocalStream.stopis called. It is being done as part of https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-515171.It is reasonable to expect that once a stream has been stopped, its effects should be disposed. Not disposing the effects means using up computing resources on effects that are no longer used. A common example is switching camera devices while VBG is enabled, which would stop the old track and add a new effect on the new track.