You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commander, the library used for the CLI, doesn't work very well with booleans, it always returns a string when the user types something like --autoReload false.
This needs to be changed to autoReload: options.autoReload === "true",
The flag is ignored and it always injects the auto-connect code and creates the server.
You can check the extension console for the logs about trying to reconnect.
Steps to Reproduce (for bugs)
webextension-toolbox dev --autoReload false <vendor>
Your Environment
Firefox.
Windows.
npm 6.13.4
The text was updated successfully, but these errors were encountered:
Expected Behavior
When sending
--autoReload false
the extension should not try to connect to the Web plugin.In here is missing
autoreload: arguments[0].autoReload,
or similarwebextension-toolbox/src/webpack-config.js
Lines 174 to 183 in c8e9955
Commander, the library used for the CLI, doesn't work very well with booleans, it always returns a string when the user types something like
--autoReload false
.This needs to be changed to
autoReload: options.autoReload === "true",
webextension-toolbox/bin/webextension-toolbox
Line 28 in c8e9955
Current Behavior
The flag is ignored and it always injects the auto-connect code and creates the server.
You can check the extension console for the logs about trying to reconnect.
Steps to Reproduce (for bugs)
webextension-toolbox dev --autoReload false <vendor>
Your Environment
Firefox.
Windows.
npm 6.13.4
The text was updated successfully, but these errors were encountered: