Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--autoReload flag not working properly #578

Closed
QtFuta opened this issue Jan 6, 2022 · 1 comment
Closed

--autoReload flag not working properly #578

QtFuta opened this issue Jan 6, 2022 · 1 comment
Assignees
Milestone

Comments

@QtFuta
Copy link

QtFuta commented Jan 6, 2022

Expected Behavior

When sending --autoReload false the extension should not try to connect to the Web plugin.

In here is missing autoreload: arguments[0].autoReload, or similar

config.plugins.push(
new WebextensionPlugin({
vendor,
manifestDefaults: {
name,
description,
version
}
})
)

Commander, the library used for the CLI, doesn't work very well with booleans, it always returns a string when the user types something like --autoReload false.
This needs to be changed to autoReload: options.autoReload === "true",

autoReload: options.autoReload,

Current Behavior

The flag is ignored and it always injects the auto-connect code and creates the server.
You can check the extension console for the logs about trying to reconnect.

Steps to Reproduce (for bugs)

webextension-toolbox dev --autoReload false <vendor>

Your Environment

Firefox.
Windows.
npm 6.13.4

@tm1000 tm1000 added this to the 5.0.0 milestone Mar 7, 2022
@tm1000
Copy link
Member

tm1000 commented Mar 7, 2022

Thanks!

@tm1000 tm1000 self-assigned this Mar 7, 2022
@tm1000 tm1000 closed this as completed in 8da2832 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants