Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request - delayed load #116

Open
Dendrek opened this issue Dec 16, 2022 · 3 comments
Open

Request - delayed load #116

Dendrek opened this issue Dec 16, 2022 · 3 comments

Comments

@Dendrek
Copy link

Dendrek commented Dec 16, 2022

This extension is one of my all-time favorites. I sincerely thank you for making it.

I have one issue. A relatively minor but persistent one: this extension never loads properly for Disqus. I think the issue is that Disqus loads a moment after the webpage loads, which also seems to be after this extension loads. I can manually load the extension by clicking it, but that's somewhat inconvenient, and I have to deal with Disqus's horrid default design until then.

The feature I'm hoping for is something like a delayed load (to only load the extension after the website is fully loaded, perhaps?) option that can be toggled or white listed. Or really, whatever solution you might come up with that would make Disqus stop being the bane of my browsing experience.

Thank you.

@webextensions
Copy link
Owner

@Dendrek
Thank you for the feature request 😀

Can you point us to a public website where Disqus is embedded in the way you are looking for?
Also, can you describe some more details of the workflow? eg: Are you using the "Pin" feature (Apply styles automatically)

PS: There may be some other bugs related to loading/auto-loading the extension for iframe which we intend to fix but may take some time before a proper resolution is done.

@Dendrek
Copy link
Author

Dendrek commented Dec 17, 2022

Hi. Thank you for the reply.

The direct Disqus website: https://disqus.com/
Two other websites that use disqus:

  • https://mangakatana.com/ (this one has the issue of the editor not loading)
  • https://reaperscans.com/ (this one seems to load the editor correctly)
  • Note: To see the disqus iframe on either of these sites you'd need to click a link to one of the novels or webtoons.

I do have the editor pinned. And on every other website I use this extension, it loads automatically without issue.

On both the disqus main website and on mangakatana, if I open these pages in a new tab the stylesheet is not automatically applied. The disqus website is an odd case because it's not an iframe. I only just noticed that reaperscans does not have this loading issue. Suggesting it may not be a universal issue with disqus and instead has something to do with how it's loaded on individual sites.

Note that once the stylesheet has been applied to a browser tab once, I can (usually) freely navigate that website and the sheet continues to be applied.

@Dendrek
Copy link
Author

Dendrek commented Dec 17, 2022

I did some more investigations on these issues.

Regarding the issue of the code not loading on mangakatana:

  • The new feature to load separate CSS for iframes requires that both the iframe CSS is pinned and also that the host page is pinned. Previously, I did not have the host page (in this case mangakatana) pinned. I had never noticed this because I didn't have any CSS applied to that webpage directly.
  • I just now pinned it and my issue on that site disappeared. In other words, Magic CSS works correctly for disqus on mangakatana as long as both instances of the CSS are pinned.

Regarding the issue of the code not loading on the disqus webpage:

  • This issue is very strange. I've noticed that if I disable another extension I'm using (uMatrix) then Magic CSS sometimes loads correctly on that site. I'm not aware of any reason why these extensions would have a conflict. However, even with uMatrix disabled, Magic CSS only sometimes loads correctly.
  • Magic CSS always shows the popup that says "Activated styles provided by Magic CSS", even when it hasn't loaded correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants