Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataNotificationManager documentation #49

Closed
petrovWF opened this issue Jan 28, 2022 · 0 comments
Closed

Fix DataNotificationManager documentation #49

petrovWF opened this issue Jan 28, 2022 · 0 comments

Comments

@petrovWF
Copy link
Contributor

This documentations contains false information(and it can be misleading) for example:
/// To obtain an instance use serviceLocator.get<NotificationsManager>()

This is not correct and should be
/// To obtain an instance use serviceLocator.get<NotificationsConsumer>()

Also we should register DataNotificationManager instance with the serviceLocator..

If we implement this changes please consider changing the logs inside DataNotificationManager that contains:
NotificationManager into NotificationConsumer..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants