New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False success when process exits involuntarily #12

Closed

brollb opened this issue Mar 9, 2019 · 0 comments

Labels

bug

Collaborator

brollb commented Mar 9, 2019

If the child process exits involuntarily, the exit code is null and the worker will treat is the same as an exit code of zero (https://github.com/webgme/executor-worker/blob/master/src/ExecutorWorker.js#L243).

brollb added the bug label

brollb mentioned this issue

Handle null exit codes and no stdout. Fixes #1205 deepforge-dev/deepforge#1206

Merged

pmeijer closed this as completed in

dfcd72f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment