Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary #7

Open
jim-rosales opened this issue Mar 7, 2018 · 0 comments
Open

Summary #7

jim-rosales opened this issue Mar 7, 2018 · 0 comments

Comments

@jim-rosales
Copy link

Grade: Meets Expectation

Summary:
Sarita, congrats on completing the Dasmoto project! Overall you did an excellent job using classes and ids appropriately in your HTML file. You also did a nice job meeting the visual specifications of the project.

A couple of things to keep in mind are syntax errors as I saw a couple in your project (#5 & #4). Browsers are very lenient when it comes to syntax and will let you get away with having errors here and there but at moments they will cause unwanted bugs, so it is best to avoid them at all cost.

As well consider reading over this style guide to improve the readability of your CSS file. I saw some inconsistencies here and there which you should try and avoid such as having a space after an opening brace .selector { vs .selector{.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant