New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channels resolver per product #33
Comments
Hi @aleho, The What do you think? |
Yes, sorry, that was a bit fuzzy. I meant: Would you accept a |
No sorry I still don't understand. The channel resolver already operates on each individual product. |
Hmm, am I a bit stupid I guess. There's the ChannelsResolverInterface which gets an array of product. I'm actually so used to seeing DTOs that my mind automatically parsed this as "array of product objects" not a product represented by an array. Sorry for the noise! |
No problem @aleho! |
If, for whatever reason, an import from a single Akeneo channel should be split for different Sylius channels (e.g. via attribute
channel
) there's currently no way to have different products land in different channels.What's your opinion on this?
Shouldn't the
ChannelsResolverInterface
rather be a singleChannelResolverInterface
operating per product instead of on all?I might be able to draft a PR next week, if you agree.
(This is probably related to #2.)
The text was updated successfully, but these errors were encountered: